-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gotrue): add reauthenticate and resend method #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the detailed check! The PR looks amazing! Just had one small thing that I missed earlier.
Let's wait to merge this until we confirm with the gotrue-js team to see if the remove session thing was intentional or not. |
## What kind of change does this PR introduce? Bug fix ## What is the current behavior? When you call the `resend` method to e.g. resend an email to change your email, you get logged out. ## What is the new behavior? On email and phone change you don't get logged out. ## Additional context I noticed this when implementing this method in gotrue-dart supabase/supabase-flutter#517 (comment)
@dshukertjr This can be merged now, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🚀
Is it possible this stopped working due to changes in the backend? I'm getting the following exception
when using
|
@haykodarb So your project is hosted on supabase and it already worked for you and stopped working now or is your project new and doesn't work? |
The project is a couple of months old, hosted on Supabase and I'm just now implementing the resend email functionality. Testing the function threw the previously mentioned exception but now I'm getting the usual
Which is fine. Not sure why it changed though, haven't changed anything on my side. Likely a reload/restart issue but I had already tried that. |
I guess your project is on the free plan? Please try to pause and unpause your project to hopefully apply the latest gotrue version. |
Yes, I'll try that, thank you. |
Paused and unpaused project, still getting this exception.
After 3 times of getting that exception I get rate limited without receiving any emails.
|
@haykodarb |
I've noticed gotrue-js contains the
reauthenticate
andresend
method, butgotrue-dart
does not.gotrue-js pr for reauthenticate.
Though I'm very unsure about the parameter for
resend
. It uses different classes and enums for phone and email