feat: handling of named prepared statements #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abc3
changed the title
2 tasks
|
Excellent description and diagram. I have only one question though: @abc3 does it mean the statement will be prepared once per db handler? Would it make sense to keep the statements in memory and, given you parse queries, when there is an attempt to execute the statement, you immediately prepare it before (which then stays prepared)? |
josevalim
approved these changes
Dec 7, 2023
yes @josevalim Thanks for the review and the excellent suggestion for improvement 🔥 |
abc3
added a commit
that referenced
this pull request
Dec 8, 2023
* call pg_query.statement_types() via rustler * handle READ ONLY SQL TRANSACTION error * clusters crud * update migrations and pool starting * safe statement_types * configs validation * feat: handling of named prepared statements (#207) * fix caller unlinking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for prepared named statements in transaction mode.
Supavisor attempts to decode all incoming queries from connected users and retrieves the SQL statement by parsing the decoded queries through an existing Rustler wrapper around
libpg_query. When the parsed query containsPrepareStmtorDeallocateStmt(which requires removing an existing named statement), theClientHandlerbroadcasts it to all otherDbHandlersin the pool.In
DbHandler, these queries accumulate in theanon_bufferlist and will be applied whendata.callerisnil. They will wait until the current PID is unlinked in cases where the process is reserved by another client