Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add informational requests into json API #10

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Conversation

kapsh
Copy link
Contributor

@kapsh kapsh commented Jul 6, 2019

Little fanciness to allow api clients fetch available features.

@supakeen
Copy link
Owner

supakeen commented Jul 6, 2019

Will take a look-see at this one tomorrow as well. For now I notice lexers is plural yet expiry is singular in the routes?

@kapsh
Copy link
Contributor Author

kapsh commented Jul 6, 2019

Agreed, changed this for consistency.

@kapsh
Copy link
Contributor Author

kapsh commented Jul 6, 2019

Sorry, just checked and learned that "expiry" is uncountable word. I will leave it as is, but perhaps you will want to rename related methods later. Every day something new.

Upd disregard that, I don't know English https://www.collinsdictionary.com/dictionary/english/expiry

Word forms: plural exˈpiries
Word forms: plural -ries

@supakeen
Copy link
Owner

supakeen commented Jul 7, 2019

This looks fine, can you please add a testcase for both these routes so I can merge them? A straightforward testcase would be to check if the count of expiries matches what is set in settings. Some examples of how to do testcases are already available in the test/ directory!

@kapsh
Copy link
Contributor Author

kapsh commented Jul 7, 2019

These tests will check that api endpoints return the same data as utilities return.

@supakeen supakeen merged commit 43b18cb into supakeen:master Jul 8, 2019
@supakeen
Copy link
Owner

supakeen commented Jul 8, 2019

Perfect, thank you.

@kapsh kapsh deleted the api_info branch July 10, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants