Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL is out of sync in Time Travel mode #8

Closed
supasate opened this issue Dec 23, 2016 · 1 comment
Closed

URL is out of sync in Time Travel mode #8

supasate opened this issue Dec 23, 2016 · 1 comment

Comments

@supasate
Copy link
Owner

Redux DevTools works fine. Time Travel works fine except the URL bar is not changed when we rewind the state.

@supasate
Copy link
Owner Author

supasate commented Dec 23, 2016

@dictions I made it as a new issue. We can leave it until there is a real need to use this feature or we can think of some better ways to do it.

I can think of a hacky way by breaking a uni-directional flow in this mode (so I don't want to use it yet). Assume we can check whether we are in time travel mode (not sure it is possible or not). When router state is changed, we push URL directly to history object if we are in the time travel mode. Then, in history.listen callback, we ignore calling props.onLocationChanged if we are in the time travel mode.

[Update] Fixed already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant