-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env BASH_SEVERITY
to specify severity of errors in shellcheck
for bash validation
#3984
Add env BASH_SEVERITY
to specify severity of errors in shellcheck
for bash validation
#3984
Conversation
Anybody help me to push this feature forward ? Like approval for CI jobs, and help me to pass the test. Thanks. |
My changes don't affect to Anyone could help? https://github.com/github/super-linter/actions/runs/4416946109/jobs/7764105838?pr=3984#step:7:243
|
The ansible issues should be fixed now, apologies for how long this took, had to dig into those failures on |
Why introduce this environment variables? Can't you set the severity in a |
Negative. |
3a790d8
to
262ff97
Compare
Thanks for the ping. And I have rebased my changes onto the latest commit of the master branch. Let's see whether it passes the CI builds. |
3419dde
to
d51a8a5
Compare
Would you like to rerun CI builds and have some reviews or guidance on this PR, as it is submitted over one month ago ? @lindluni |
8c22b81
to
b713804
Compare
b713804
to
bd40a69
Compare
Thanks for the merge and help from @lindluni and @ferrarimarco. Is this feature available in the github action only when it's released in the next tag? |
It will be available on the “latest” tag once this workflow completes: https://github.com/github/super-linter/actions/runs/4717260552 |
I will get a 5.0.1 published later this week for pinning purposes so the Action can be used directly |
No problem. I will try to apply this feature in Apache Kyuubi for bash shell check when it's available in action. |
Hi, a kind ping to @lindluni . It seems the Therefor, this feature is unavailable with the |
Proposed Changes
Currently bash validation is executed with
severity
in the default value ofstyle
, which makes too manyinfo
level messages thrown and causes failures in usingsuper-linter
. For the users only cares about severity of warning and above, there's no way to config it insuper-linter
.shellcheck
for bash validation by adding BASH_SEVERITY env--severity
inshellcheck
(https://github.com/koalaman/shellcheck/blob/master/shellcheck.1.md#options)Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance