sc-ide: fix behaviour of right context button when out of tab #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When right -clicking in the tab area, but outside of a tab, the Close and Close Tabs to the right options do not make sense, and in fact Close crashes the editor. Treat this case to offer to close all tabs.
|
lgtm |
|
Works as expected on OSX Qt 5.5. Nice fix! Would be good for 3.7 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When right -clicking in the tab area, but outside of a tab, the Close
and Close Tabs to the right options do not make sense, and in fact Close
crashes the editor.
Treat this case to offer to close all tabs.