Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PSinGrain #3494

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Fix PSinGrain #3494

merged 2 commits into from
Feb 6, 2018

Conversation

patrickdupuis
Copy link
Contributor

No description provided.

This patch adds a missing update of the member variable in the plugin
code.
This is mainly for ear protection. Existing uses may fall quiet. But
those must have been hacks around the broken current behaviour anyway.
@patrickdupuis
Copy link
Contributor Author

First time trying @brianlheim's wonderful cherry-picking script. Did I get it right?

@patrickdupuis patrickdupuis added this to the 3.9.2 milestone Feb 4, 2018
@mossheim
Copy link
Contributor

mossheim commented Feb 4, 2018

@patrickdupuis nice! You should try the new version of the script; it will reference the original (so the link will appear in the other PR's conversation) and also includes a link to the script itself.

https://gist.github.com/brianlheim/7809f7a062362f0ea3ff1490ae12694b

@patrickdupuis
Copy link
Contributor Author

patrickdupuis commented Feb 4, 2018 via email

Copy link
Member

@telephon telephon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a correct rebase, thank you.

@telephon telephon mentioned this pull request Feb 6, 2018
@nhthn nhthn changed the title Cherry-picking #3493 onto 3.9 Fix PSinGrain Feb 6, 2018
@mossheim
Copy link
Contributor

mossheim commented Feb 6, 2018

This works, awesome!

@telephon telephon merged commit f7018fa into supercollider:3.9 Feb 6, 2018
@patrickdupuis patrickdupuis deleted the 3493 branch March 1, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants