New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PSinGrain #3494

Merged
merged 2 commits into from Feb 6, 2018

Conversation

Projects
None yet
4 participants
@patrickdupuis
Copy link
Contributor

patrickdupuis commented Feb 4, 2018

No description provided.

telephon added some commits Feb 4, 2018

plugins: PSinGrain now counts down correctly
This patch adds a missing update of the member variable in the plugin
code.
plugins: standardise PSinGrain default amplitude
This is mainly for ear protection. Existing uses may fall quiet. But
those must have been hacks around the broken current behaviour anyway.

@patrickdupuis patrickdupuis requested a review from brianlheim Feb 4, 2018

@patrickdupuis

This comment has been minimized.

Copy link
Contributor

patrickdupuis commented Feb 4, 2018

First time trying @brianlheim's wonderful cherry-picking script. Did I get it right?

@patrickdupuis patrickdupuis added this to the 3.9.2 milestone Feb 4, 2018

@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Feb 4, 2018

@patrickdupuis nice! You should try the new version of the script; it will reference the original (so the link will appear in the other PR's conversation) and also includes a link to the script itself.

https://gist.github.com/brianlheim/7809f7a062362f0ea3ff1490ae12694b

@patrickdupuis

This comment has been minimized.

Copy link
Contributor

patrickdupuis commented Feb 4, 2018

@telephon
Copy link
Member

telephon left a comment

looks like a correct rebase, thank you.

@telephon telephon referenced this pull request Feb 6, 2018

Closed

Topic fix psingrain #3493

@snappizz snappizz changed the title Cherry-picking #3493 onto 3.9 Fix PSinGrain Feb 6, 2018

@brianlheim

This comment has been minimized.

Copy link
Member

brianlheim commented Feb 6, 2018

This works, awesome!

@telephon telephon merged commit f7018fa into supercollider:3.9 Feb 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment