UnitTest - remove debug posts and inline warnings #4716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellmusik
approved these changes
Jan 3, 2020
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Some UnitTest subclasses post unnecessary debug info,
some have var declarations that post compiler inline warnings.
This PR removes both, so unit tests run as quietly as possible.
Types of changes
cleanup for UnitTests.
Code is tested
All tests are passing *
No documentation update needed
This PR is ready for review
*That is, TestPattern, TestServer_boot, TestReadableNodeIDAllocator run fine.
On my setup, I cannot get the LPCtests to run properly,
with or without the changes proposed here...