Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Feat/python preparation #304

Merged
merged 5 commits into from
Jul 7, 2023

Conversation

Jakub-Vacek
Copy link
Member

@Jakub-Vacek Jakub-Vacek commented Jul 5, 2023

Description

This PR updates code base to be able to add more languages in future (now adding python). PR introduces SupportedLanguages enum, these are used in application code generation and dependency definition generation.

Final project requirements (python version, dependencies) are not 100% confirmed yet, but possible use of python is hidden so this can be merged.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly. For updating Oclif commands documentation use oclif-dev.
  • I have read the CONTRIBUTION_GUIDE document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@kysely kysely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It overall looks okay 👍

Just left a comment about how we're switching between the languages because I think the current solution might be prone to introducing bugs in the future.

src/common/file-structure.ts Outdated Show resolved Hide resolved
@Jakub-Vacek Jakub-Vacek requested a review from kysely July 7, 2023 06:02
Copy link
Member

@kysely kysely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

I now it is more code but I feel like it's safer

@Jakub-Vacek Jakub-Vacek merged commit 78c55be into release/x-cli-functionality Jul 7, 2023
3 checks passed
@Jakub-Vacek Jakub-Vacek deleted the feat/python-preparation branch July 7, 2023 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants