Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Feat/update python sdk #312

Merged
merged 16 commits into from
Jul 12, 2023
Merged

Conversation

Jakub-Vacek
Copy link
Member

@Jakub-Vacek Jakub-Vacek commented Jul 10, 2023

Description

This PR updates Python related code to use correct syntax and dependencies.
Use of python is functional (for map and execute) but still hidden.
Waiting on OneSdks python beta.1

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly. For updating Oclif commands documentation use oclif-dev.
  • I have read the CONTRIBUTION_GUIDE document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Jakub-Vacek Jakub-Vacek changed the base branch from main to release/x-cli-functionality July 10, 2023 16:10
…cli into feat/update-python-sdk

# Conflicts:
#	src/logic/application-code/python/application-code.test.ts
#	src/logic/application-code/python/application-code.ts
@Jakub-Vacek Jakub-Vacek marked this pull request as ready for review July 11, 2023 07:37
Copy link
Member

@kysely kysely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, just a comment on Node.js dep version

src/logic/project/js/js.ts Outdated Show resolved Hide resolved
@kysely kysely merged commit 422aa7c into release/x-cli-functionality Jul 12, 2023
3 checks passed
@kysely kysely deleted the feat/update-python-sdk branch July 12, 2023 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants