Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup example projects #502

Merged
merged 26 commits into from
Nov 29, 2021
Merged

Cleanup example projects #502

merged 26 commits into from
Nov 29, 2021

Conversation

hellwolf
Copy link
Contributor

@hellwolf hellwolf commented Nov 22, 2021 •
edited by saflamini
Loading

Checklist

  • removed dev-playground
  • removed react-ts-sdk
  • updated example projects' dependencies
  • handler.build-examples.yml to support generic build-and-test.sh as build step
  • include streaming-call-option
  • include nftbillboard-userdata

@saflamini
Copy link
Contributor

  1. Added build-and-test.sh file to 2 additional examples
  2. Added test cases to 2 additional examples
  3. Fixed errors in flowlottery build script

@hellwolf all examples built and ran successfully. Please let me know if you see something I may have missed

@hellwolf
Copy link
Contributor Author

@saflamini looks good!

0xdavinchee
0xdavinchee reviewed Nov 29, 2021
View reviewed changes
...aming-call-option/artifacts/@openzeppelin/contracts/introspection/ERC165.sol/ERC165.dbg.json Outdated
@@ -1,4 +1,4 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's best to add all artifacts or any sort of generated files in .gitignore.

kasparkallas
kasparkallas approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@kasparkallas kasparkallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the example frond-end apps with MetaMask when hosted on a site like https://codesandbox.io

examples/README.md Show resolved Hide resolved
examples/streaming-call-option/hardhat.config.js Show resolved Hide resolved
@hellwolf hellwolf merged commit 3c5503f into dev Nov 29, 2021
@hellwolf hellwolf deleted the cleanup_example_projects branch November 29, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdavinchee 0xdavinchee 0xdavinchee left review comments

@kasparkallas kasparkallas kasparkallas approved these changes

@saflamini saflamini saflamini approved these changes

Assignees

@saflamini saflamini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hellwolf @saflamini @kasparkallas @0xdavinchee