Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation for MemoryIncrementsMB #478

Closed
simonw opened this issue Jul 30, 2021 · 2 comments · Fixed by #540
Closed

Missing documentation for MemoryIncrementsMB #478

simonw opened this issue Jul 30, 2021 · 2 comments · Fixed by #540
Labels
bug Something isn't working

Comments

@simonw
Copy link
Contributor

simonw commented Jul 30, 2021

If I run flyctl platform vm-sizes --json one of the fields I get back is called MemoryIncrementsMB:

{
    "Name": "dedicated-cpu-8x",
    "CPUCores": 8,
    "MemoryGB": 16,
    "MemoryMB": 16384,
    "PriceMonth": 248,
    "PriceSecond": 0.00009568,
    "MemoryIncrementsMB": [
        16384,
        32768,
        65536
    ]
}

I can't find any documentation about what this means.

Are these the only allowed values to pass to --memory when scaling an app to use that VM size?

If so, it conflicts with the documentation on https://fly.io/docs/flyctl/scale-vm/ which says about --memory:

For dedicated vms, this should be a multiple of 1024MB.

@mrkurt
Copy link
Member

mrkurt commented Jul 30, 2021

MemoryIncrementsMB is an internal implementation detail you shouldn't need to know about, but it's leaking.

Our VM sizes have a base memory amount and then an allowed additional memory amount. When you run fly scale vm shared-cpu-1x --memory 1024 we do magic to abstract that. I'm guessing this is only in the API output for displaying VM sizes, but it's pretty gross: https://github.com/superfly/flyctl/search?q=MemoryIncrementsMB

The allowed values for --memory are MemoryMB + MemoryIncrementMB

@simonw
Copy link
Contributor Author

simonw commented Jul 30, 2021

The allowed values for --memory are MemoryMB + MemoryIncrementMB

Does that mean the information on this page is out-of-date? https://fly.io/docs/flyctl/scale-vm/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants