-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add favorites and playlists #162
Conversation
@@ -1,14 +1,14 @@ | |||
module.exports = [ | |||
{name: 'favorites', author: 'You!', title: 'Your Saved Favorites'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there are still some formatting isssues. See space around {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are spaces around the newly added lines, that's consistent with semistandard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Objects should be {name: 'favorites', author: 'You!', title: 'Your Saved Favorites'}
no space before / after curly braces
src/lib/convert-beatmap.js
Outdated
@@ -1,6 +1,10 @@ | |||
module.exports = function convertBeatmap (src) { | |||
if (src.converted) return src; | |||
|
|||
if (src['map']) { | |||
src = src['map']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can just assign? src = src['map'];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively. src = src['map'] || src;
No description provided.