Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wrap aligned images in paragraphs in Markdown #110

Closed
sapegin opened this issue Jul 2, 2018 · 4 comments
Closed

Do not wrap aligned images in paragraphs in Markdown #110

sapegin opened this issue Jul 2, 2018 · 4 comments
Labels

Comments

@sapegin
Copy link
Member

sapegin commented Jul 2, 2018

Example — book covers on landings:

<p>
  <figure><img src="/8f86c1d07d5536454690030cd1a10b53.png" alt="SurviveJS - Webpack" 
    class="front-cover" width="255" height="329" />
  <figcaption>SurviveJS - Webpack</figcaption></figure>
</p>
...

This creates undesired whitespace.

@sapegin sapegin added the bug label Jul 2, 2018
@sapegin
Copy link
Member Author

sapegin commented Jul 3, 2018

We could probably extract book covers into React.

@bebraw
Copy link
Member

bebraw commented Jul 3, 2018

The wrapping comes from the Markdown parser likely. Here's how to do it: https://github.com/GraphQLFinland/site/blob/master/components/Markdown.js . That solution needs to grow to fit the needs of this site, though.

@sapegin
Copy link
Member Author

sapegin commented Jul 3, 2018

I mean it doesn't make much sense to put cover into Markdown on landings if we override how they look anyway.

@bebraw
Copy link
Member

bebraw commented Jul 3, 2018

That's true. They can live outside of Markdown for sure.

@sapegin sapegin mentioned this issue Jul 4, 2018
19 tasks
@sapegin sapegin closed this as completed Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants