Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifiy sentences in suse-best-practices/xml/MAIN-SBP-AMD-EPYC-3-SLES15SP2.xml #175

Closed
chabowski opened this issue Mar 9, 2021 · 8 comments
Assignees
Labels

Comments

@chabowski
Copy link
Collaborator

the <quote>distance</quote>. This should be considered when tuning for <emphasis

Hi Dario @dfaggioli
can you clarify the following sentence:

This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses are not necessarily to local memory incurring a variable access penalty.

should it be:

This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses are not necessarily incurring a variable access penalty to local memory.

or:

This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses are not necessary to local memory incurring a variable access penalty.

It is not completely clear currently. Thank you very much!

@chabowski
Copy link
Collaborator Author

@dfaggioli Next sentence to clarify:

"What is not obvious is the links to the IO die, but it should be taken into account when splitting a workload to optimize bandwidth to memory."

"Not obvious are the links to the IO die, but this () should be taken into account .... "
"Not obvious are the links to the IO die, but the IO die should be taken into account ...."

@chabowski
Copy link
Collaborator Author

@dfaggioli and one more:

In addition to lstopo can provide the information, the level, size and ID of CPUs that share cache can be identified from the files under /sys/devices/system/cpu/cpuN/cache.

Options:

"In addition to lstopo which can provide the information, the level, size and ID of CPUs that share cache can be identified from the files under /sys/devices/system/cpu/cpuN/cache."

"In addition, lstopo can provide the information, the level, size and ID of CPUs that share cache, which can be identified from the files under /sys/devices/system/cpu/cpuN/cache."

@chabowski chabowski changed the title Clarifiy sentence Clarifiy sentences in suse-best-practices/xml/MAIN-SBP-AMD-EPYC-3-SLES15SP2.xml Mar 9, 2021
@dfaggioli
Copy link
Contributor

dfaggioli commented Mar 10, 2021

the <quote>distance</quote>. This should be considered when tuning for <emphasis

Hi Dario @dfaggioli
can you clarify the following sentence:

This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses are not necessarily to local memory incurring a variable access penalty.

I think it means that it can happen that a memory operation accesses some remote (i.e., non-local) memory. That is, memory accesses not necessarily always happen to local memory, which mean they can incur a variable access penalty.

So, this, I would say:

This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses are not necessary to local memory incurring a variable access penalty.

However, can we double check with @gormanm , as I think this comes from him ?

@dfaggioli
Copy link
Contributor

@dfaggioli Next sentence to clarify:

"What is not obvious is the links to the IO die, but it should be taken into account when splitting a workload to optimize bandwidth to memory."

This sentence is right below the figure fig-epyc-topology. I think it means that it is not obvious, by looking at that figure, how the various CCXs/dies (which are shown in the figure itself) are connected to the IO die (which is not present in the figure because the tool does not draw it).

But again, @gormanm would be the one source of truth here. :-)

@dfaggioli
Copy link
Contributor

@dfaggioli and one more:

In addition to lstopo can provide the information, the level, size and ID of CPUs that share cache can be identified from the files under /sys/devices/system/cpu/cpuN/cache.

Options:

"In addition to lstopo which can provide the information, the level, size and ID of CPUs that share cache can be identified from the files under /sys/devices/system/cpu/cpuN/cache."

"In addition, lstopo can provide the information, the level, size and ID of CPUs that share cache, which can be identified from the files under /sys/devices/system/cpu/cpuN/cache."

This is still from @gormanm . Personally, I'd go for something like:

"In addition to the information that lstopo can provide, the level, size and ID of CPUs that share cache can be identified from the files under /sys/devices/system/cpu/cpuN/cache."

But we should really double check with him (plus, I'm no native Eng. speaker, so don't trust me!)

@gormanm
Copy link
Contributor

gormanm commented Mar 10, 2021

the <quote>distance</quote>. This should be considered when tuning for <emphasis

Hi Dario @dfaggioli
can you clarify the following sentence:
This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses are not necessarily to local memory incurring a variable access penalty.

I think it means that it can happen that a memory operation accesses some remote (i.e., non-local) memory. That is, memory accesses not necessarily always happen to local memory, which mean they can incur a variable access penalty.

So, this, I would say:

This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses are not necessary to local memory incurring a variable access penalty.

However, can we double check with @gormanm , as I think this comes from him ?

The switch from "necessarily" to "necessary" changes the semantics of the sentence. Alternative suggestion as follows

This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses may not reference local memory incurring a variable access penalty.

@gormanm
Copy link
Contributor

gormanm commented Mar 10, 2021

@dfaggioli and one more:

In addition to lstopo can provide the information, the level, size and ID of CPUs that share cache can be identified from the files under /sys/devices/system/cpu/cpuN/cache.

Options:

"In addition to lstopo which can provide the information, the level, size and ID of CPUs that share cache can be identified from the files under /sys/devices/system/cpu/cpuN/cache."

This version is the best.

@gormanm
Copy link
Contributor

gormanm commented Mar 10, 2021

@dfaggioli Next sentence to clarify:

"What is not obvious is the links to the IO die, but it should be taken into account when splitting a workload to optimize bandwidth to memory."

"Not obvious are the links to the IO die, but the IO die should be taken into account ...."

This option is the better of the two. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants