-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifiy sentences in suse-best-practices/xml/MAIN-SBP-AMD-EPYC-3-SLES15SP2.xml #175
Comments
@dfaggioli Next sentence to clarify: "What is not obvious is the links to the IO die, but it should be taken into account when splitting a workload to optimize bandwidth to memory." "Not obvious are the links to the IO die, but this () should be taken into account .... " |
@dfaggioli and one more: In addition to lstopo can provide the information, the level, size and ID of CPUs that share cache can be identified from the files under /sys/devices/system/cpu/cpuN/cache. Options: "In addition to lstopo which can provide the information, the level, size and ID of CPUs that share cache can be identified from the files under /sys/devices/system/cpu/cpuN/cache." "In addition, lstopo can provide the information, the level, size and ID of CPUs that share cache, which can be identified from the files under /sys/devices/system/cpu/cpuN/cache." |
I think it means that it can happen that a memory operation accesses some remote (i.e., non-local) memory. That is, memory accesses not necessarily always happen to local memory, which mean they can incur a variable access penalty. So, this, I would say:
However, can we double check with @gormanm , as I think this comes from him ? |
This sentence is right below the figure But again, @gormanm would be the one source of truth here. :-) |
This is still from @gormanm . Personally, I'd go for something like: "In addition to the information that lstopo can provide, the level, size and ID of CPUs that share cache can be identified from the files under /sys/devices/system/cpu/cpuN/cache." But we should really double check with him (plus, I'm no native Eng. speaker, so don't trust me!) |
The switch from "necessarily" to "necessary" changes the semantics of the sentence. Alternative suggestion as follows This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses may not reference local memory incurring a variable access penalty. |
This version is the best. |
This option is the better of the two. Thanks! |
suse-best-practices/xml/MAIN-SBP-AMD-EPYC-3-SLES15SP2.xml
Line 122 in c08df52
Hi Dario @dfaggioli
can you clarify the following sentence:
This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses are not necessarily to local memory incurring a variable access penalty.
should it be:
This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses are not necessarily incurring a variable access penalty to local memory.
or:
This should be considered when tuning for Non-Uniform Memory Architecture (NUMA) as all memory accesses are not necessary to local memory incurring a variable access penalty.
It is not completely clear currently. Thank you very much!
The text was updated successfully, but these errors were encountered: