Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndexPool: _getAmountOut over/underflow + self-division #50

Closed
technicallyty opened this issue Aug 13, 2021 · 0 comments
Closed

IndexPool: _getAmountOut over/underflow + self-division #50

technicallyty opened this issue Aug 13, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@technicallyty
Copy link
Contributor

Summary

  • typo/logic err in the _getAmountOut function of IndexPool.sol see: L269 where it is dividing tokenBalanceIn by itself.

  • the _getAmountOut function in IndexPool.sol is currently throwing an under/overflow error. see tests on this branch: RoutingIndex.test.ts.
@technicallyty technicallyty added the bug Something isn't working label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ro5s @technicallyty