Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PWA notices for caching and updating #12

Closed
nai888 opened this issue May 9, 2018 · 1 comment
Closed

Add PWA notices for caching and updating #12

nai888 opened this issue May 9, 2018 · 1 comment
Assignees
@nai888
Labels
enhancement enhancement to the site's features or functionality

Comments

@nai888
Copy link
Collaborator

nai888 commented May 9, 2018 •
edited
Loading

Review the create-react-app README's recommendations for creating a fully functioning progressive web app, and the offline behavior in particular.

Check out this page for help with notifying about available updates.

This code will be handled at around line 63 of registerServiceWorker.js.

Check out react-toastify as a possible way to handle the notifications themselves.

Langua Version

0.1.3

Desired Behavior

Add a notice for when the browser has cached the app and it can be accessed offline. Ideally, also notify users they can add Langua to the home screen of their mobile or tablet.

Add a notice when the server's version of Langua is different from the cached version, indicating that the user should refresh the page to load the newer version.
@nai888 nai888 added the enhancement enhancement to the site's features or functionality label May 9, 2018
@nai888 nai888 self-assigned this May 9, 2018
nai888 added a commit that referenced this issue May 10, 2018
@nai888
Add toast notifications
e8f6227 
Add react-toastify for handling notifications. Add unstyled notifications for caching and update availability. Change position and transition type for notifications. #12
@nai888
Copy link
Collaborator Author

nai888 commented May 10, 2018 •
edited
Loading

Still need to:

  • notify users that they can add the app to their mobile/tablet homescreen.
  • notify users when an internet connection is unavailable and the app is being served from the cache.
  • style the notifications according to the site's branding.

nai888 added a commit that referenced this issue May 10, 2018
@nai888
Add links to relevant issues from CHANGELOG
0efd943 
Added links to issues #9, #10, and #12 to CHANGELOG
nai888 added a commit that referenced this issue May 10, 2018
@nai888
Finish toast notifications, fix other bugs
616474e 
Add "no internet connection found" toast notification. Style all three toast notifications. This completes issue #12. Add basic function for the Open button to preventDefault. Refactor localization of stats numbers. Add notice about Langua being a PWA on the home page.
@nai888 nai888 closed this as completed May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nai888 nai888

Labels
enhancement enhancement to the site's features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nai888