src/lang.c: 2 * bad parameter to va_start ?

[dcb314]

src/lang.c:59]: (warning) 'msgstr' given to va_start() is not last named argument of the function. Did you intend to pass 'msgid'?

Source code is

int lang_print(FILE *const file, const enum MessageID msgid, ...) {
char *msgstr = lang_getmsg(msgid);
if(msgstr == NULL) return -1;

    va_list args;
    va_start(args, msgstr);

Also:

src/lang.c:71]: (warning) 'msgstr' given to va_start() is not last named argument of the function. Did you intend to pass 'number'?

Duplicate.

[suve]

This is as intended - lang_print() takes a message ID as a parameter, whereas va_start() expects a format string. The ID is resolved to a message string via the lang_getmsg() call.

Apart from adding some comments saying "this will emit a warning, this is intended", or maybe some #pragma GCC directives, I don't really see what can be changed here.

[dcb314]

Suggest look again. I checked the reference manual for C and the only thing va_start
is documented to work with is the last named parameter. This is different to the local variable
it is given in your code.

[suve]

Oh, truly. For whatever reason I was convinced that va_start() expects a format string, like printf(). Though thinking about it now, that wouldn't make much sense.

[suve]

Fixed in f55e41b.