Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.sharedlibrary on OSX should use -installname instead -soname #1828

Open
degyves opened this issue Jan 4, 2018 · 1 comment
Open

Comments

@degyves
Copy link

degyves commented Jan 4, 2018

On OSX High Sierra with clang and GNU Make 3.81, Apple LLVM version 9.0.0 (clang-900.0.39.2):

make will stop since -soname is unknown. On lines 49 and 52 of dist/Makefile.sharedlibrary they should be changed to -installname:

line 49: $(CC) -shared -fPIC -Wall -Wextra -Os -Wl,-install_name,libduktape.so.$(SONAME_VERSION) \

line 53: $(CC) -shared -fPIC -g -Wall -Wextra -Os -Wl,-install_name,libduktaped.so.$(SONAME_VERSION) \

@svaarala
Copy link
Owner

svaarala commented Jan 4, 2018

As background information, the Makefiles in the distributable are not intended for production use and are not generally portable to all targets Duktape itself ports to. There are simply too many targets for them to be officially supported; for instance, the sharedlibrary Makefile simply provides an example how one can roughly compile Duktape as a shared library, and the details may vary depending on the target (even for Linux targets).

That said, if there's a simple diff that will make it work on OSX and won't break it on Linux, I'll be happy to apply the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants