Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License doesn't get detected properly by license-checker, leading to false negative #33

Closed
regexident opened this issue Jul 10, 2024 · 1 comment · Fixed by #36
Closed

Comments

@regexident
Copy link
Contributor

Describe the bug

Running the following command

npx license-checker --production --excludePrivatePackages --onlyAllow "MIT" --onlyunknown

… in a project that uses paneforge@0.0.4 results in:

└─ paneforge@0.0.4
   ├─ licenses: MIT*
   ├─ repository: https://github.com/huntabyte/paneforge
   ├─ publisher: Hunter Johnston
   ├─ url: https://github.com/huntabyte
   ├─ path: <SNIP>/node_modules/paneforge
   └─ licenseFile: <SNIP>/node_modules/paneforge/LICENSE

The MIT* here denotes that license-checker could not find a license and thus had to make a guess based on the file contents of licenseFile, which depending on your CI configuration may lead to a false negative.

The package's npm page also lists a License of none.

Reproduction

n/a

Logs

No response

System Info

n/a

Severity

annoyance

@regexident
Copy link
Contributor Author

The package also seems to still list an outdated repository url: https://github.com/huntabyte/paneforge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant