-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename params
to slugs
in load
#3634
Rename params
to slugs
in load
#3634
Comments
params
to slugs
in load
I had suggested
|
interesting, and I agree with Rich that "slugs.slug" seems weird, but params seems as bad name as well... just today I found at least 4 people at Discord that were confused about this. We should think more about what name would be good there. maybe |
|
actually we don't want to change request object as it's instance of Request, so it would be fine to have same... better to change params, not sure if entries would be good name for it... "values" is like, what is it? Not self-descripted... |
@Mlocik97 Oops, I didn't mean to say |
But I'm OK with |
Yeah, my thought process behind |
Unless we can find a name that's unambiguously better than ...and Remix: It shouldn't be the overriding consideration, but there's value in using the same terminology as the wider ecosystem. |
Describe the problem
in load function we have instead of page now parameters url and params... params is derived from url.pathname, but url has also property url.searchParams... because of that it's kind of confusing as "params" can now refer to both parameters like
?x=value
or to params like/[slug]/
... I even twice was burned on that I did "const params = url.searchParams" in load function and rewrited params object from params of load function. (see, a lot of params word in this sentence)....Describe the proposed solution
let url be url, and params be named slugs
Alternatives considered
No response
Importance
nice to have
Additional Information
No response
The text was updated successfully, but these errors were encountered: