Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync latest code from Sapper #6

Closed
benmccann opened this issue Oct 13, 2020 · 6 comments
Closed

Sync latest code from Sapper #6

benmccann opened this issue Oct 13, 2020 · 6 comments
Milestone

Comments

@benmccann
Copy link
Member

benmccann commented Oct 13, 2020

E.g. compare https://github.com/sveltejs/kit/tree/master/packages/kit/src/client vs https://github.com/sveltejs/sapper/tree/master/runtime/src/app

We'll have to come up with a strategy for this because there have been a lot of fixes and improvements recently. I can slow down on merging Sapper stuff if it makes it easier to manage

@Rich-Harris Rich-Harris transferred this issue from another repository Oct 15, 2020
@benmccann benmccann mentioned this issue Oct 22, 2020
@Rich-Harris
Copy link
Member

I've copied over all the router code — is there anything else you can think of? If not, we can close this issue

@Rich-Harris Rich-Harris added this to the whenever milestone Oct 29, 2020
@benmccann
Copy link
Member Author

benmccann commented Oct 29, 2020

@ehrencrona you might want to check if sveltejs/sapper#1498 got ported over to Kit. I tried looking, but the page store type is still TODO, so I wasn't sure:

sveltejs/sapper#1569 might be a good one to check as well

@Rich-Harris
Copy link
Member

pretty sure we can close this now, i'm sure we'll find out in due course if not

@benmccann
Copy link
Member Author

I think we almost have all of this done. The one I think we haven't yet is sveltejs/sapper#1498 - store the current error in the page store to allow the layout to know whether the current page is an error page

@Rich-Harris
Copy link
Member

Given that it only applies to the root layout I think I'd prefer that we pass the error (and possibly status) as a prop. It doesn't belong on the page store

@benmccann
Copy link
Member Author

Ok. Created a separate issue for that (#598) and will close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants