This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 434
non-page route should not set content-type #109
Comments
Hi @samhatchett! That's a very good point. That line of code you linked should possible be moved here instead? |
looks right to me. mind if I open a PR? |
I think that would make Rich a very happy man. |
I think a similar change should also be made here. This forcing of js content-type is I believe the only thing stopping custom assets by webpack from working (extract-text-plugin for css or file-loader for font assets, for examples). |
primary issue fixed via #111 - similar change from @jacobmischka not yet addressed. |
The core issue here is fixed so I'll close this, but I've opened a new ticket (#116) for the related issue @jacobmischka found |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
https://github.com/sveltejs/sapper/blob/master/lib/index.js#L200
... does not check for route type. by setting a default type of
text/html
, Sapper ends up overriding useful auto-checking of mime types by express, especially for download content.The text was updated successfully, but these errors were encountered: