Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Don't assume /client/** assets are JS #116

Closed
Rich-Harris opened this issue Feb 6, 2018 · 3 comments
Closed

Don't assume /client/** assets are JS #116

Rich-Harris opened this issue Feb 6, 2018 · 3 comments
Labels
bug

Comments

@Rich-Harris
Copy link
Member

Moving #109 (comment) into its own separate issue — this line (and the related line in connect_prod) prevents certain webpack plugins from being used
@Rich-Harris Rich-Harris added the bug label Feb 6, 2018
@Rich-Harris Rich-Harris mentioned this issue Feb 6, 2018
Closed
@EmilTholin
Copy link
Member

EmilTholin commented Feb 9, 2018 •
edited
Loading

Could this be solved by removing this and this line of code, and let Express derive the Content-Type automatically?

@Rich-Harris
Copy link
Member Author

Related: Sapper will actually generate a script tag for all route assets, even non-JS ones...

https://gitter.im/sveltejs/svelte?at=5a99baf56fba1a703abf5043

This was referenced Mar 4, 2018
Merged
Open
@jacobmischka
Copy link

jacobmischka commented Mar 15, 2018 •
edited
Loading

Is this indeed fixed in #153? Should this be closed now?

I can confirm this is fixed (with the #154 caveat) and should be closed, thanks, great work!

@Rich-Harris Rich-Harris mentioned this issue Jun 28, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Rich-Harris @jacobmischka @EmilTholin @Conduitry