Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Do not encode characters allowed in path when generating routes #234

Merged
merged 1 commit into from
May 4, 2018

Conversation

akihikodaki
Copy link
Contributor

In RFC 3986, some characters not allowed in query, which encodeURIComponent
is designed for, is allowed in path.
A notable example is "@", which is commonly included in paths of social
profile pages. Such characters should not be encoded.

The new encoding function is conforming to the RFC.

In RFC 3986, some characters not allowed in query, which encodeURIComponent
is designed for, is allowed in path.
A notable example is "@", which is commonly included in paths of social
profile pages. Such characters should not be encoded.

The new encoding function is conforming to the RFC.
@Rich-Harris Rich-Harris merged commit d7a2132 into sveltejs:master May 4, 2018
@Rich-Harris
Copy link
Member

Thank you, this is so helpful! I had no idea about the distinction.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants