This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Am in two minds about this one. In #308, if you have something like
routes/foo/bar/baz.html
but don't have (say)routes/foo/index.html
, Sapper will import a fallback component that looks like this:Since
routes/foo/index.html
would probably look like that anyway, we can a) save the developer some typing, b) avoid clutteringroutes
, and c) prevent the situation where you have multiple components that look like that, duplicated unnecessarily, which is good for file size. You'd then only need to create an intermediateindex.html
file if you needed specific markup or behaviour.However, it's less explicit, and it's possible to create a webpack config that breaks it, by only compiling components inside
routes
.So for now I'm just going to leave it here as a PR to the original PR.