Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency chai to v5 #458

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 28, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
chai (source) ^4.4.1 -> ^5.0.0 age adoption passing confidence

Release Notes

chaijs/chai (chai)

v5.1.0

Compare Source

What's Changed

New Contributors

Full Changelog: chaijs/chai@v5.0.3...v5.1.0

v5.0.3

Compare Source

Fix bad v5.0.2 publish.

Full Changelog: chaijs/chai@v5.0.2...v5.0.3

v5.0.2

Compare Source

What's Changed

Full Changelog: chaijs/chai@v5.0.1...v5.0.2

v5.0.0

Compare Source

BREAKING CHANGES

  • Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have import {...} from 'chai' or import('chai'). require('chai') will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls.
  • Dropped support for Internet Explorer.
  • Dropped support for NodeJS < 18.
  • Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome 100, Edge 100. Support for browsers prior to these versions is "best effort" (bug reports on older browsers will be assessed individually and may be marked as wontfix).

What's Changed

New Contributors

Full Changelog: chaijs/chai@4.3.1...v5.0.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

changeset-bot bot commented Dec 28, 2023

⚠️ No Changeset found

Latest commit: e0c4bbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot force-pushed the renovate/chai-5.x branch 2 times, most recently from 21ddecd to ed69135 Compare January 13, 2024 07:22
@baseballyama
Copy link
Member

😇

Chai now only supports EcmaScript Modules (ESM).

https://github.com/chaijs/chai/releases/tag/v5.0.0

What we will do @ota-meshi ?
Maybe we can use mocha as same as eslint-plugin-vue?

ESLint itself still seems to be using v4.
https://github.com/eslint/eslint/blob/60b966b6861da11617ddc15487bd7a51c584c596/package.json#L112

@baseballyama baseballyama marked this pull request as draft January 21, 2024 03:21
@ota-meshi
Copy link
Member

I don't think we can use ESM-only packages now.
If we do make this a dual package with ESM in the future, I don't think we can drop ESM until ESLint removes support for legacy configs (legacy configs will be deprecated in ESLint v9) .
However, I think there is a possibility that the test could be devised to test only the ESM.

@baseballyama
Copy link
Member

I may have understood it wrong to begin with, but I understood that ESLint doesn’t support ESM and must be built with commonjs.
Therefore, I understood that the test runner must also support commonjs.
Since mocha seemed to support commonjs, I thought this might be one of the solutions.
ESLint v9 still use commonjs, so we can't use ESM, can we?

@renovate renovate bot force-pushed the renovate/chai-5.x branch 7 times, most recently from 7df355f to e9e3a71 Compare January 27, 2024 22:46
@renovate renovate bot force-pushed the renovate/chai-5.x branch 9 times, most recently from 30248e0 to 4b38203 Compare February 26, 2024 22:04
@renovate renovate bot force-pushed the renovate/chai-5.x branch 5 times, most recently from 41b8c6b to 30bfb18 Compare February 29, 2024 12:04
@renovate renovate bot force-pushed the renovate/chai-5.x branch 5 times, most recently from 9ca0377 to d89fca0 Compare March 25, 2024 21:26
@renovate renovate bot force-pushed the renovate/chai-5.x branch 10 times, most recently from 9d14a18 to 2fc2676 Compare April 9, 2024 00:30
@renovate renovate bot force-pushed the renovate/chai-5.x branch 8 times, most recently from 928b91a to adaddc5 Compare April 29, 2024 22:42
@renovate renovate bot force-pushed the renovate/chai-5.x branch 4 times, most recently from 282e625 to 424445e Compare May 9, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants