-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issues with Svelte 4 / 5 interop and deep_read
#10628
Comments
I know #10624 was done today did you try with latest? |
If I understand correctly, this was deployed to the REPL before I opened this issue. Anyway, I'll close this and open a new issue simply because I think I can provide a much more simplified REPL. It was 1:30 last night 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I've ported over a demo of my virtual list from Svelte 4:
https://svelte.dev/repl/65779175ebc0493392bdf718f6eecb2a?version=4.2.12
to Svelte 5 (using runes and snippets):
https://svelte-5-preview.vercel.app/#H4sIAAAAAAAAA41YbY_bNhL-KxOnxcq7suXtIl-89vbaS4ML0CAHpHfBoS5aWhxZvKVIHknZVgz99wNJvVC7GyD5kiU1Mxw-88JnfJkVjKOZrX-_zASpcLae_aTULJ3ZRrmFOSK3OEtnRtY6dzsbk2um7MNOALBKSW3hAlJ8kLWwKUjxFo3VsoEWCi0ruAoWru4j-X8zbWvCf2XGdkLLLNpbjipOiaMFw6qaE4vvECls4TtjicXE6hrn973MXspHM34UeIKftCZNcrv6c7VazZcF4zwRNefzZUVUkvyZApvD9gEuO7GzO6vR1lq4Ffh_jK6Bpf3KMstxDZ-sZuKQfCC2XGoiqKyS-bwTap2ddj6PHM-lsIQJ1KNjo8cm15Lz36QaP67Gr4PqP5AdSgtbmAg5sSyDd-yMFJjFCsogxwQodkZulp3IbyUzkMuaU8hlhUCZxtzyJmBPwFipERJcHpbACqgNagM5Ec6Dgh1qjWBLjMy71b_ez3v7HzXsEShqdkQ6NWpLYqGUnBqvtCcGoZDCBfRLf6Q774XjRjEmoJG1BqJUfGZOeO6TgkJtmDjA248flvC5JBaPqIOKxv_VTGOFwhogGpc9uA6wAde7VRSxQpMKhyBYVqHuvha1yC2TApTkPJn3icIKSIZYLceYvtpuxwjPx7SKo_6C3v2YS_4P7w9s_VXQ2J8Eq4jz4p3bT5wrIWU6ha4Sk6TP7G-3EWSzDD511QauhiixBIjW7MjEYRlkPCqwBYP2vbCoj4RPDwyovIrLNkIAIJTafb8xXBagkBoSHyHYwuoeGGxgUmxwDbdu_-ZmYtFX_1LVpkyi3VDE4RtHcbBlGn_8hpr27s1f8rTvN_7_Pmop3K66Gm57TIeeOMUoJyJH_tV4AuQciR7w9ZhHljfZ0Ih3YlPePvzs_bnEl203WXkbBCg7Qs6JMdvdzIvsZrBngq5tycz2MiRiG3ZzzlDYUCHR17DR-ua_idu4qyezDYe3cBnLq4Vn2nAZkt1Zcq338toIphRa0PKUePUUaF1VTQpNO2-D1M4-u8ZuFpZrLwzGNhy3u5mVan1pWnW-3838ESFkl9esgFdetH3tT1ky2sIiOLz06dBeMla0vc4mo-zYO5l1Trb--vGT9eDi0UmKjQr47GtrpQD3kjpv_Wo3Aykcuvnj9hLSIekT6fc_5u3DL5WyzSYL0sEOJ3vkDxsmVG17a3mJ-eNenvso-jXS7SUuuRayh7GYC_d2JkQpFNRXto_ZfJMF--4GKvjvUfRnL4NvXcbKI-qCy9MaSG3l2DGuwxPDDPy3dk-61L6DU6xkGvpwCLhr0uOD6Fp-SY4IRDSh0cN1Fizupaao13CrzmAkZxRer1arrixOjNpyDW9WKxdevxWepnivq1Pvf-9-dg3_kbU_l3Aj3cMDTHAmcHHQjAIRFCgWTCC49cJipRxyi2uQ4dFTRKMIF0RiGjiGDPDig_OUGcVJs-5t77nMH3vfS2ZxYRTJcQ1CnjRRMYwfBU60QKEGt0xBSCilZl8cfDzCM8LsvDDsCxOHdYffYi97gBSh1H9ZwWr5RmM1xfJ2tfr-_mmMS0Yp9j3a4tkuxm_IOVOGmdj5zwgaFx5Ul1hwKtGj1gBHF2YH4JHhyVPAfQOEumxxd7AlMg2-anczOBJe43Ct7BreoktZJyg7JuAOyR2XaGQNlX_FSV4yPCLs0Vp0D7-puTUdM7CaCONCeUfhBk6M80VeEnEYj1HSMNeF16CRE8uOGF_tLVYSjMKcFSx3LSo0GjOi32fg3ZiUPowv7Dti4yKFa7h9M-wOIbNWVpPMv7u7m6R06HSXqPYwtMqhAIkAJo7MsD1HQNdQAkGMMP25tu6JdvidiLCBqHFXLE1fIrlLbd6ARkFRA7PA2aOr1s5kjpw_qdhFLrnU64B3KJbe9U3Wd5VZOqskZQVDOls7Ct-mw-wRtdRvnUGyDD67TAuRJvDXGEpjWf7Y_AUlEncDqaGQ0gZuCMK1QytBEWNifltiRBMv4R0IagNfXKVhO9h9tu3Tv_v7ydsXSUw2hgcx7UYRefKzhBsMlJbKJD2ZyKUwNsT7U1PtJYcthD-Sqy4LLFZX86ec1XCWY5iHiNYpGEu0TQHFSMyIdpyOaL30wkkkMhSDAwXPCnOL9FfPMWDrJGARLMY08n0BJwQqxZUNjR6FrA9l3x7winNwM5lLrVrBidmyS2QUVjM0y8GUf18q8ogGHLlvbBmCzaV1nZihTj0yzFjXoF0n52gMID3gwnWKZjk0YI7gIOgoEmye3CdilU7KM8oI7vlTft5NjUTruEpH3EtW2Aj33LHz4Ywsg7_7wUxpuSd73rhJSirLKvYFaQp7V6YWdC2Ma36-uqn8gm5ZdEAa6XvWedm3l-cE2h_6lDO729XC--fxUFIl8-h6X7-cs86lsUPmf9cNf8mkIm4mdeNzyDrVrjM913468S6iU0Z1_3rq59qevlfknEzspwGlPtrXUe3NR5uirt57MJ_ay5HxqUHIYhNwA7eRa64E3guK52eGCi6lTsbZL3vZERT0mX5k9WbwdOL7xyNqTtRXlL5_QcnTi-cYDjhMcBq0DlzuCf9YFAYnarG1a_jKfSOh6MK-1UwcHwsm6lmhp0YApwNU8zSCYP58NIpHhpA7u9kwKPTv8yXOqjA3gCWOWuN5u5stbv0c4SYIJHnZeU0MhEnFi3VDyuVv3YPpJ5l-cHFy6_AKb7fbSf_-EWoRaCeFIJL2Wl7sZbVBpllPw3IDiXcHNnFm_DiJ-BpW86DvZyuAS-au1U6mmGgKCOD0rWNKGgdK8U-NR_RUAkfCRbsm5X8V2nNEGgifdi9BCjkJz3blfiwaSW3PKl4go8NxP6x-uJ2S5ZIo1bjO63-fGLlZRLhWL3Gz1bdwlD_a_wOmDr6kKxUAAA==
According to performance recordings it performs even better than Svelte 4. Amazing!
However, during porting I noticed the following: if I keep
VirtualList.svelte
in Svelte 4 code and only portApp.svelte
then performance tanks massively.Svelte 4:
Svelte 5:
Mix:
Reproduction
Open the REPLs and scroll up/down, here's the mixed 4/5 one:
https://svelte-5-preview.vercel.app/#H4sIAAAAAAAAA41YbY_bNhL-KxMnxcq7tmV3kS9ea4v0csEFaJAD0jY41EVLiyOLtxSpIymvFcP__TCkXujNBki-xCKHw5ln3h7uaVIIiXay_uM0UazCyXrypq4ns4lra_qwB5QOJ7OJ1Y3JaWVjcyNqd79VAKKqtXFwAq0-6Ea5GWj1Fq0zuoUzFEZXcBU0XN1F8r8L4xomfxHWdUKLNFpbjEfokEQHVlSNZA7fIXLI4JV1zGHiTIPTu15mp_WDHTcVPsIbY1ibrJZ_LZfL6aIQUiaqkXK6qFidJH_NQEwhu4fTVm3d1hl0jVH0Bf6f4GsQs_7LCSdxDZ-cEWqffGCuXBimuK6S6bQTOpOe83QaGZ5r5ZhQaEbDRottbrSUv-p63FyOu8PRf6HYlw4yuBAisTSFd-KIHITDCsogJxTU4ojSLjqRX0thIdeN5JDrCoELg7mTbcCegXXaICS42C9AFNBYNBZypsiCQuwbg-BKjNTT12_vp73-jwZ2CByNOCC_VOpK5qDUklt_aMcsQqEVBfRLfyXd98x1o5hQ0OrGAKvr-M6cydwnBYfGCrWHtx8_LOBzyRwe0IQjBv_XCIMVKmeBGVz04BJgA663yyhihWEVDkFwokLT7RaNyp3QCmotZTLtE0UUkAyxWowxfZFlY4SnY1rFUX_m3N2YS_6Htwcy7wpa90aJipEV72g9IVNCynQHukpMkj6zv19HkE1T-NRVG1ANceYYMGPEQaj9Ish4VCADi-69cmgOTF5eGFB5EZdthABAKLW7fmFwFqDQBhIfIchgeQcCNnBRbHANK1q_ubnQ6Kt_UTe2TKLVUMRhT6Lau3IWb35HTXvzps9Z2vcb_38ftRmsll0Nn3tMh554iVHOVI7ym_EEyCUyM-DrMY80b9KhEW_Vplzd_-ztOcXOnjdpuQoCXBwgl8zabDvxItsJ7ITia1cKm52GRDyH1VwKVC5USLQbFs6--W_iNk71ZLNw-RlOY3md4avTcBqS_UxFtvbdi37wpqpa_6u9Dxh8Zfd2Ej47Wetaidl24nS9PrXn-ni3ndz3ETq9FAW88ILnl96mheBnmAf7Fj7651MqinN3WcrFIfgWz6N7AjvsbNWmDgK7xjmtgMYkWea_thPQiqDLH7JTiHXSZ8kff07P9_-satdu0iAd9Ei2Q3m_EapuXK8tLzF_2OljHyL_jTw7xfV0hvR-rNSCBmPC6hoV92XrAzLdpEE_eVAH-z1i_u5FsK1LR31AU0j9uAbWOD22g-swP4SF_zY0r7Xx7ZljpWehyYZoUgcepx3185IdEJhqQxeH6zRo3GnD0axhVR_Baik4vFwul13OPwruyjW8Xi4plH4pzJ14rStCb39vfnoN_9GNv5dJq2mqgFBSKJzvjeDAFAeOhVAI9D13WNWE3PwadJhoNTOogoPIbAuHkAFefDCeC1tL1q573Tup84fe9lI4nNua5bgGpR8Nq2MYPyq8OAU1GqDPGSgNpTbiC8EnIzwjzI5zK74ItV93-M13ugeoZpz7nSUsF68NVpdYrpbLH-6exrgUnGPfgB0e3XzcQylFbYWNjf-MYHDuQaXEgscSPWpUrRRmAvAg8NHzu10LjFO2kA-uRGHAV-h2AgcmGxzcSq_hLVLKkqDuxjxdkhNRaHUDlR_RLC8FHhB26BzSVLeNdLYb-84wZSmUtxxu4FFIOc9LpvbjNbW2glrsGgxK5sQBY9feYqXB1piLQuRg9GNoKnZEv8_A2zEpfRifWSfWQpHCNaxeD6tDyJzT1UXm397eXqR06GqnqPYQwlpfgEyBUAdhxU4iIDWUwP4iTH9uHM1fwu-RKRdYmKRiafsSySm1ZQsGFUcDwoEUD1StncocpXxSsfNcS23WAe9QLL3pm7TvKpPZpNJcFAL5ZE38_DwbHhZRS_3eB0aawmfKtBBpBn-PobRO5A_t31AiIw-0gUJrF4gfKGqHTkPNrI3Ja4kdB8Sjz1RP-PyxgQyGThTthwu-ve8L4unik5n33Jnnd2IeSFu5VtaFFPjUVjstIYPwI7nqEsNhdTV9ylGtFDmG9w8zZgbWMeNmgGokYswQh2PGLLxwEokM9UEm4bHG3CH_xXMKyEgC5kFjTBvfF_CIwLW6cqH3o9LNvuw7Bl5JCfQGo2xrangUruxyG5UzAu1iUOVHTsUe0AKR-daVIf5SO2rOAs3MIyOso55NzV2itYB8j3NqHu1i6MkSgSDoKBFsnvgTsUiS8gwygnv6lI93r0RmTFy4I-6lKFyEe05sfLgjTeEf_iFWG71jO9nSy0nXTlTiC_IZ7KhyHZhGWeqHvuC5_oL0WXRAWu3b2HHRd5yvCbO_9ClHJu8a5e3zeNS6TqaRe9927tUapLZuKIGLiri5KKC7Tr5rUMORp4_ZeaSxP-Mn51hono5X7Jhc6JoFFPpoXkelNO0VqaZ676HqlOQo5KUWSONzcAOrwQjK6veK47E_XUitTTK-2tLnrkTF-0ORhpvBlMi0jwc0ktWXkj98Jek5wgDG4NL1097xag17qXdMfiwKiyQbn7z-lg-R0OCEbwNk15jDURvxuM8io2eD19NZ5NjXj5OYw4cgbycDc--H6CkOfyDy4BjxXzxm28l81RH700tkednZyqyHYwZerKfxVmo3vEMdVpnn-5Bl2UUj_QkaFSghh7UXPPenvNjzxwaZNjtdAH8DibcCNnGUf7oIxxqW005BGrxJyZvzxQsjYugBk76GLwndMO7_bfCAfszjSIZ41y38n2N2EpEHMmaoJc8gZ2GkVvRXmpFw9hP_GaI4XPfj8sfVJZEtWV231AL9HwZG3hSRoeVzvGn5Pfzhz_P_AaOyYL6kFAAA
Logs
No response
System Info
Severity
blocking an upgrade
The text was updated successfully, but these errors were encountered: