Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped styles in a component marketplace #1080

Closed
arxpoetica opened this issue Jan 7, 2018 · 2 comments
Closed

Scoped styles in a component marketplace #1080

arxpoetica opened this issue Jan 7, 2018 · 2 comments

Comments

@arxpoetica
Copy link
Member

arxpoetica commented Jan 7, 2018

See: #1070 (comment)

In essence can a marketplace component's styles be a) replaced globally or b) overridden by another stylesheet.

I think there's a very fundamental question here on whether we decide that a component even ought to be styled globally. In other words, the prevailing philosophy, as I understand it, is that scoping is explicit to the component for a reason: so it remains untouched by the global environment.

Still there's something to be said for classnames and default cascading rules.

[This one's a real debate...I feel conflicted about it...]

@arxpoetica
Copy link
Member Author

One thought is this could be decided by a flag in the component itself:

export default {
    [...component stuff...]
    classname: true, // alternately, classname: '.name-of-class' ... something like that...
}

@arxpoetica
Copy link
Member Author

There appears to be another issue for this, so I'll mark it up as such and close this one. See #901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant