Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript linting for compiler source #2895

Closed
run1t opened this issue May 28, 2019 · 2 comments
Closed

Add typescript linting for compiler source #2895

run1t opened this issue May 28, 2019 · 2 comments

Comments

@run1t
Copy link

run1t commented May 28, 2019

The compiler source are now all in typescript maybe it can be a good idea to add a tslint.json to ensure the consistency of the code.

Related to #2890, c8fbde4.

By the way 8fd94ae remove some functionalities from eslint but in c8fbde4 eslint seems to be removed.

@maxmilton
Copy link
Contributor

Rather than using TSLint which will be deprecated, it would be better to add TypeScript support to ESLint instead. See https://github.com/typescript-eslint/typescript-eslint.

I've been using this in my projects and other than some known performance issues (which I'm sure will be ironed out soon) it works great. Some TSLint rules are not yet available but are rapidly being added to that project.

@run1t
Copy link
Author

run1t commented Jun 4, 2019

Yes you're right ! Didn't notice that 😄

I will close this one and open a new one: Add TypeScript support to ESLint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants