-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[site] /repl/embed doesn't work with gists #4866
Comments
https://github.com/sveltejs/svelte/blob/master/site/src/routes/repl/embed.svelte appears to not have been updated as part of #2572 and is still expecting a response of the form that would be returned by GitHub's Gist API. |
@Conduitry Should I look into a fix for this or is possible for this to be a quick fix? I would like to embed the repl in my site |
Thinking about this more, this doesn't seem like something we want to actually support, at least not while the site is being hosted entirely out of Rich's pocket. Providing a free embeddable REPL sounds like a great way to burn through extra bandwidth, and a great way to get a lot of people angry at us if we decide to change anything or pull the plug on it if it gets too expensive.
|
I wasn't aware that he was hosting the site entirely out of his money, so in that case I'd agree. I still think someone should look into making the repl easy to embed self hosted, but that would be a different issue. |
The implementation doesn't rely on gists anymore. We have sveltejs/sites#93 regarding embedding |
Describe the bug
Looking through site/src/routes/repl/embed.svelte, it looks like the repl embed doesn't work with gists, even though it looks like it should.
This: https://svelte.dev/repl/7f9ca904fc4a4cd09a0e55883a3aa9e5 does work
So this: https://svelte.dev/repl/embed?gist=7f9ca904fc4a4cd09a0e55883a3aa9e5 should too
The text was updated successfully, but these errors were encountered: