Typed SvelteComponent interface #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2020 12:12
You need to type it like CustomEvent<...> because when forwarding events it could also be MouseEvent or sth like that
orta
approved these changes
Oct 12, 2020
|
Is this ready to use in component libraries? |
|
@Conduitry this is ready to merge. I'll open a separate PR for docs. |
tanhauhau
reviewed
Oct 27, 2020
let people type it loose themselves if they want to
|
The has been released in 3.30.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for RFC sveltejs/rfcs#37
I tested this locally with the language-tools and it works.
I also noticed that the current type definition is wrong: When you forward an event like
<button on:click ...and you listen to the event through$on('click', ..., the type according to the current type definition would beCustomEvent<MouseEvent>, but it'sMouseEvent.