Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix rvalue error when using arrow functions in {@const} #7222

Merged
merged 3 commits into from Apr 8, 2022

Conversation

baseballyama
Copy link
Member

fix: #7206

In addition to #7206, I added support for various more edge cases.
I have tried to cover as much as possible, but please let me know if there are any omissions.

I noticed that the process of {@const} is similar to {#if}. I looked for a way to completely reuse the processing of {if}, but I couldn't implement it.
If you have any ideas on how to do this, I would appreciate your comments.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@baseballyama
Copy link
Member Author

There is multiple issues that will be fixed by this PR. can someone review this?

#7423
#7431
#7206

@tanhauhau
Copy link
Member

tanhauhau commented Apr 8, 2022

sorry hijacking your PR, i've modified the implementation to fix #7221 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment