[fix] Fixing const tag replacing memeber expressions properties. #7329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7326.
Member expressions in const tags get replaced if there is an overlap with local variables in the each block.
EG:
In
{@const otherThing = otherThings.find(ot => ot.id.id === id)}
, ifid
is present in the current each block scope all instances ofid
is replaced, even inot.id.id
.This PR fixes the issue by checking if parent is a
MemberExpression
and theIdentifier
is not aproperty
ofMemberExpression
Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint