Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixing const tag replacing memeber expressions properties. #7329

Closed
wants to merge 1 commit into from
Closed

Conversation

AdityaHegde
Copy link

@AdityaHegde AdityaHegde commented Mar 2, 2022

Fixes #7326.
Member expressions in const tags get replaced if there is an overlap with local variables in the each block.
EG:
In {@const otherThing = otherThings.find(ot => ot.id.id === id)}, if id is present in the current each block scope all instances of id is replaced, even in ot.id.id.
This PR fixes the issue by checking if parent is a MemberExpression and the Identifier is not a property of MemberExpression

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@gtm-nayan
Copy link
Contributor

Likely related #7222

@baseballyama
Copy link
Member

I think this PR considered more cases.

@AdityaHegde
Copy link
Author

@baseballyama Agreed.

@AdityaHegde AdityaHegde closed this Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object property access in callbacks within @const statements are being treated as separate variables
3 participants