Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't optimize svelte/ssr #138

Closed
dominikg opened this issue Aug 12, 2021 · 0 comments · Fixed by #139 or #140
Closed

don't optimize svelte/ssr #138

dominikg opened this issue Aug 12, 2021 · 0 comments · Fixed by #139 or #140
Labels
bug Something isn't working

Comments

@dominikg
Copy link
Member

Describe the bug

svelte/ssr is only used on ssr build, so doesn't need to be optimized. As older versions of svelte don't export it, it can lead to an error where vite can't optimize the missing export

Reproduction

sveltejs/kit#2181

Logs

No response

System Info

.

Severity

blocking an upgrade
@dominikg dominikg added bug Something isn't working triage Awaiting triage by a project member labels Aug 12, 2021
@dominikg dominikg mentioned this issue Aug 12, 2021
Merged
@github-actions github-actions bot mentioned this issue Aug 12, 2021
Merged
@dominikg dominikg removed the triage Awaiting triage by a project member label Aug 16, 2021
@github-actions github-actions bot mentioned this issue Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@dominikg