Skip to content

Commit

Permalink
golangci-lint fails to run due to revives unknown time-equal ru…
Browse files Browse the repository at this point in the history
…le (#77)

The `time-equal` rule [1] was added in GH-64 [2], but the `revive`
linter [3] used by `golangci-lint` does not yet include the rule in the
current release version [4] but only merged it into the `main` branch.
Therefore linting failed because the rule is not known (yet) and
`golangci-lint` exits before running any linter.
To fix the problem the `time-equal` rule has been disabled again for now
and will be enabled again when it is available in a new `revive` version
that is used by `golangci-lint`.

[1]: https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#time-equal
[2]: #64
[3]: https://github.com/mgechev/revive
[4]: https://github.com/mgechev/revive/releases/tag/v1.1.2

Closes GH-76
  • Loading branch information
svengreb committed Nov 23, 2021
1 parent 5218029 commit ab32672
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ linters-settings:
- name: string-of-int
severity: error
- name: superfluous-else
- name: time-equal
- name: time-naming
- name: unconditional-recursion
- name: unexported-naming
Expand Down

0 comments on commit ab32672

Please sign in to comment.