New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`golangci-lint` fails to run due to `revive`s unknown `time-equal` rule #77

Merged

svengreb merged 1 commit into main from bugfix/gh-76-disable-unknown-revive-time-equal-rule

Nov 23, 2021

Owner

svengreb commented Nov 23, 2021

Fixes #76

svengreb added type-bug context-techstack scope-compatibility labels

svengreb added this to the 0.10.1 milestone

svengreb self-assigned this

svengreb merged commit ab32672 into main

svengreb deleted the bugfix/gh-76-disable-unknown-revive-time-equal-rule branch

November 23, 2021 16:21

svengreb removed their assignment


          golangci-lint fails to run due to revives unknown time-equal rule

f723d5a

The `time-equal` rule [1] was added in GH-64 [2], but the `revive`
linter [3] used by `golangci-lint` does not yet include the rule in the
current release version [4] but only merged it into the `main` branch.
Therefore linting failed because the rule is not known (yet) and
`golangci-lint` exits before running any linter.
To fix the problem the `time-equal` rule has been disabled again for now
and will be enabled again when it is available in a new `revive` version
that is used by `golangci-lint`.

[1]: https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#time-equal
[2]: #64
[3]: https://github.com/mgechev/revive
[4]: https://github.com/mgechev/revive/releases/tag/v1.1.2

GH-76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment