-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golangci-lint
fails to run due to revive
s unknown time-equal
rule
#76
Milestone
Comments
svengreb
added a commit
that referenced
this issue
Nov 23, 2021
The `time-equal` rule [1] was added in GH-64 [2], but the `revive` linter [3] used by `golangci-lint` does not yet include the rule in the current release version [4] but only merged it into the `main` branch. Therefore linting failed because the rule is not known (yet) and `golangci-lint` exits before running any linter. To fix the problem the `time-equal` rule has been disabled again for now and will be enabled again when it is available in a new `revive` version that is used by `golangci-lint`. [1]: https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#time-equal [2]: #64 [3]: https://github.com/mgechev/revive [4]: https://github.com/mgechev/revive/releases/tag/v1.1.2 GH-76
svengreb
added a commit
that referenced
this issue
Nov 23, 2021
…le (#77) The `time-equal` rule [1] was added in GH-64 [2], but the `revive` linter [3] used by `golangci-lint` does not yet include the rule in the current release version [4] but only merged it into the `main` branch. Therefore linting failed because the rule is not known (yet) and `golangci-lint` exits before running any linter. To fix the problem the `time-equal` rule has been disabled again for now and will be enabled again when it is available in a new `revive` version that is used by `golangci-lint`. [1]: https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#time-equal [2]: #64 [3]: https://github.com/mgechev/revive [4]: https://github.com/mgechev/revive/releases/tag/v1.1.2 Closes GH-76
svengreb
added a commit
to svengreb/wand
that referenced
this issue
Nov 23, 2021
Updated to `tmpl-go` version `0.11.0` [1] which... 1. fixed `golangci-lint` running errors due to `revive`s unknown `time-equal` rule [2]. 2. disabled the `revive` linter rule `package-comments` [3]. See the full `tmpl-go` version `0.10.1` changelog [1] for all details. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.10.1 [2]: svengreb/tmpl-go#76 [3]: svengreb/tmpl-go#78 GH-112
svengreb
added a commit
to svengreb/wand
that referenced
this issue
Nov 23, 2021
Updated to `tmpl-go` version `0.11.0` [1] which... 1. fixed `golangci-lint` running errors due to `revive`s unknown `time-equal` rule [2]. 2. disabled the `revive` linter rule `package-comments` [3]. See the full `tmpl-go` version `0.10.1` changelog [1] for all details. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.10.1 [2]: svengreb/tmpl-go#76 [3]: svengreb/tmpl-go#78 Closes GH-112
svengreb
added a commit
to svengreb/nib
that referenced
this issue
May 9, 2022
Updated to `tmpl-go` version 0.12.0 [1], including the versions in between starting from 0.7.0 [3]: 1. Updated to Go 1.17 [4]. 2. Updated to golangci-lint `v1.43.0` [5]. 3. Updated to `tmpl` template repository version `0.11.0` [6]. 4. Optimized GitHub action workflows for Go and Node [7]. 5. Disabled golangci-lint's default excluded issues [8]. 6. Introduced Go dependency caching and build outputs in `ci-go` workflow [9]. 7. Disabled revive linter rule `package-comments` [10]. 8. Fixed golangci-lint fail to run due to `revives` unknown `time-equal` rule [11]. 9. updated Node.js packages & GitHub actions [12]. This also included changes required for any linter matches. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.12.0 [3]: https://github.com/svengreb/tmpl-go/releases/tag/v0.7.0 [4]: svengreb/tmpl-go#66 [5]: svengreb/tmpl-go#64 [6]: svengreb/tmpl-go#91 [7]: svengreb/tmpl-go#68 [8]: svengreb/tmpl-go#72 [9]: svengreb/tmpl-go#74 [10]: svengreb/tmpl-go#78 [11]: svengreb/tmpl-go#76 [12]: svengreb/tmpl-go#42 GH-62
svengreb
added a commit
to svengreb/nib
that referenced
this issue
May 9, 2022
Updated to `tmpl-go` version 0.12.0 [1], including the versions in between starting from 0.7.0 [3]: 1. Updated to Go 1.17 [4]. 2. Updated to golangci-lint `v1.43.0` [5]. 3. Updated to `tmpl` template repository version `0.11.0` [6]. 4. Optimized GitHub action workflows for Go and Node [7]. 5. Disabled golangci-lint's default excluded issues [8]. 6. Introduced Go dependency caching and build outputs in `ci-go` workflow [9]. 7. Disabled revive linter rule `package-comments` [10]. 8. Fixed golangci-lint fail to run due to `revives` unknown `time-equal` rule [11]. 9. updated Node.js packages & GitHub actions [12]. This also included changes required for any linter matches. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.12.0 [3]: https://github.com/svengreb/tmpl-go/releases/tag/v0.7.0 [4]: svengreb/tmpl-go#66 [5]: svengreb/tmpl-go#64 [6]: svengreb/tmpl-go#91 [7]: svengreb/tmpl-go#68 [8]: svengreb/tmpl-go#72 [9]: svengreb/tmpl-go#74 [10]: svengreb/tmpl-go#78 [11]: svengreb/tmpl-go#76 [12]: svengreb/tmpl-go#42 GH-62
svengreb
added a commit
to svengreb/nib
that referenced
this issue
May 9, 2022
Updated to `tmpl-go` version 0.12.0 [1], including the versions in between starting from 0.7.0 [3]: 1. Updated to Go 1.17 [4]. 2. Updated to golangci-lint `v1.43.0` [5]. 3. Updated to `tmpl` template repository version `0.11.0` [6]. 4. Optimized GitHub action workflows for Go and Node [7]. 5. Disabled golangci-lint's default excluded issues [8]. 6. Introduced Go dependency caching and build outputs in `ci-go` workflow [9]. 7. Disabled revive linter rule `package-comments` [10]. 8. Fixed golangci-lint fail to run due to `revives` unknown `time-equal` rule [11]. 9. updated Node.js packages & GitHub actions [12]. This also included changes required for any linter matches. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.12.0 [3]: https://github.com/svengreb/tmpl-go/releases/tag/v0.7.0 [4]: svengreb/tmpl-go#66 [5]: svengreb/tmpl-go#64 [6]: svengreb/tmpl-go#91 [7]: svengreb/tmpl-go#68 [8]: svengreb/tmpl-go#72 [9]: svengreb/tmpl-go#74 [10]: svengreb/tmpl-go#78 [11]: svengreb/tmpl-go#76 [12]: svengreb/tmpl-go#42 GH-62
svengreb
added a commit
to svengreb/golib
that referenced
this issue
May 10, 2022
Updated to `tmpl-go` version `0.12.0` [1], including the versions in between starting from 0.7.0 [3]: 1. Updated to Go 1.17 [4]. 2. Updated to golangci-lint `v1.43.0` [5]. 3. Updated to `tmpl` template repository version `0.11.0` [6]. 4. Optimized GitHub action workflows for Go and Node [7]. 5. Disabled golangci-lint's default excluded issues [8]. 6. Introduced Go dependency caching and build outputs in `ci-go` workflow [9]. 7. Disabled revive linter rule `package-comments` [10]. 8. Fixed golangci-lint fail to run due to `revives` unknown `time-equal` rule [11]. 9. Updated Node.js packages & GitHub actions [12]. This also includes changes required for any linter matches. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.12.0 [3]: https://github.com/svengreb/tmpl-go/releases/tag/v0.7.0 [4]: svengreb/tmpl-go#66 [5]: svengreb/tmpl-go#64 [6]: svengreb/tmpl-go#91 [7]: svengreb/tmpl-go#68 [8]: svengreb/tmpl-go#72 [9]: svengreb/tmpl-go#74 [10]: svengreb/tmpl-go#78 [11]: svengreb/tmpl-go#76 [12]: svengreb/tmpl-go#42 GH-41
svengreb
added a commit
to svengreb/golib
that referenced
this issue
May 10, 2022
Updated to `tmpl-go` version `0.12.0` [1], including the versions in between starting from 0.7.0 [3]: 1. Updated to Go 1.17 [4]. 2. Updated to golangci-lint `v1.43.0` [5]. 3. Updated to `tmpl` template repository version `0.11.0` [6]. 4. Optimized GitHub action workflows for Go and Node [7]. 5. Disabled golangci-lint's default excluded issues [8]. 6. Introduced Go dependency caching and build outputs in `ci-go` workflow [9]. 7. Disabled revive linter rule `package-comments` [10]. 8. Fixed golangci-lint fail to run due to `revives` unknown `time-equal` rule [11]. 9. Updated Node.js packages & GitHub actions [12]. This also includes changes required for any linter matches. [1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.12.0 [3]: https://github.com/svengreb/tmpl-go/releases/tag/v0.7.0 [4]: svengreb/tmpl-go#66 [5]: svengreb/tmpl-go#64 [6]: svengreb/tmpl-go#91 [7]: svengreb/tmpl-go#68 [8]: svengreb/tmpl-go#72 [9]: svengreb/tmpl-go#74 [10]: svengreb/tmpl-go#78 [11]: svengreb/tmpl-go#76 [12]: svengreb/tmpl-go#42 GH-41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
time-equal
rule was added in #64, but therevive
linter used bygolangci-lint
does not yet include the rule in the current release version but only merged it into themain
branch. Therefore linting currently fails because the rule is not known (yet) andgolangci-lint
exits before running any linter.To fix the problem the
time-equal
rule will be disabled for now and will be enabled again when it is available in a newrevive
version that is used bygolangci-lint
.The text was updated successfully, but these errors were encountered: