Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint fails to run due to revives unknown time-equal rule #77

Merged
merged 1 commit into from
Nov 23, 2021
Merged

golangci-lint fails to run due to revives unknown time-equal rule #77

merged 1 commit into from
Nov 23, 2021

Commits on Nov 23, 2021

  1. golangci-lint fails to run due to revives unknown time-equal rule 

    The `time-equal` rule [1] was added in GH-64 [2], but the `revive`
linter [3] used by `golangci-lint` does not yet include the rule in the
current release version [4] but only merged it into the `main` branch.
Therefore linting failed because the rule is not known (yet) and
`golangci-lint` exits before running any linter.
To fix the problem the `time-equal` rule has been disabled again for now
and will be enabled again when it is available in a new `revive` version
that is used by `golangci-lint`.

[1]: https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#time-equal
[2]: #64
[3]: https://github.com/mgechev/revive
[4]: https://github.com/mgechev/revive/releases/tag/v1.1.2

GH-76
    @svengreb
    svengreb committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    f723d5a View commit details
    Browse the repository at this point in the history