Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point numbers not materializing correctly #34

Closed
webwarrior-ws opened this issue Jul 16, 2022 · 1 comment
Closed

Floating point numbers not materializing correctly #34

webwarrior-ws opened this issue Jul 16, 2022 · 1 comment

Comments

@webwarrior-ws
Copy link

Some floats are have different values after materialization due to loss in precision when doing arithmetic operations in STONReader.
Some examples: 0.022999999999999854, 4.999999999999996, Float fmin.
This should not occur and all values must be exactly the same after serializing and materializing.

@svenvc
Copy link
Owner

svenvc commented Jul 18, 2022

Please see a995911

I added further comments to your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants