-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The rust crate does not work. #21
Comments
@Maple0817 I published a new one, please try it. If you have other problem, must tell me! |
@SyMind , 2 things could imporve:
|
@Maple0817 What does this mean? Can you explain it in detail. |
@SyMind this is a sample svg code, the class="icon" is not transformed. so one warning will happen: |
|
@Maple0817 I fix second problem in #23. But i have no idea to change String to Error, because i don't have much experience with the actual design for Rust library, what are the advantages of using Error? Can you help make changes? |
@SyMind You can use thiserror crates. It looks like pub enum SvgrRsError { pub fn fn1() -> Result<String, SvgrRsError> { Since some functions should be changed include the napi, I am afraid would break other function. |
When I add it in toml, add use svgr_rs in rs; an error no external crate svgr_rs is happened.
Meanwhile, could you provide a sample code that how to use the crate in rust? seems the config is also not public.
The text was updated successfully, but these errors were encountered: