Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plugin package name parse #106

Merged
merged 7 commits into from
Oct 9, 2019
Merged

Refactor plugin package name parse #106

merged 7 commits into from
Oct 9, 2019

Conversation

xuchaoying
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

refactor

  • What is the related issue? (Use #issue_id to relate an open issue)

  • Does this PR introduce a breaking change?

no

  • Other information:

refactor plugin package name parse:

svrx-plugin-foo -> foo
@scope/svrx-plugin-foo -> @scope/foo 

@xuchaoying xuchaoying added the PR: internal :house: Internal label Sep 25, 2019
@xuchaoying xuchaoying requested a review from a team September 25, 2019 03:00
@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #106 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   91.98%   92.06%   +0.08%     
==========================================
  Files          44       44              
  Lines        1584     1601      +17     
==========================================
+ Hits         1457     1474      +17     
  Misses        127      127
Impacted Files Coverage Δ
packages/svrx/lib/util/helper.js 100% <100%> (ø) ⬆️
packages/svrx/lib/configure/index.js 98.74% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e171f...5f2bf30. Read the comment docs.

packages/svrx/lib/util/helper.js Show resolved Hide resolved
packages/svrx/lib/util/helper.js Outdated Show resolved Hide resolved
packages/svrx/lib/util/helper.js Outdated Show resolved Hide resolved
@xuchaoying xuchaoying merged commit 39f65c7 into master Oct 9, 2019
@xuchaoying xuchaoying deleted the cy-official-plugin branch October 9, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: internal :house: Internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants