Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed podtrac prefixing of mp3 urls #3

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Allowed podtrac prefixing of mp3 urls #3

merged 1 commit into from
Mar 21, 2019

Conversation

erikras
Copy link
Collaborator

@erikras erikras commented Mar 20, 2019

From PodTrac docs:

Measurement Service 2019-03-20 23-11-01

☝️ That's literally all this PR does.

@erikras
Copy link
Collaborator Author

erikras commented Mar 20, 2019

An alternative design might be to pass a "url decorator" function that would default to the identity function x => x, but that would allow consumers of the podcats library to modify their mp3URL at their whim.

@swyxio swyxio merged commit e600455 into swyxio:master Mar 21, 2019
@swyxio
Copy link
Owner

swyxio commented Mar 21, 2019

https://github.com/sw-yx/podcats/releases/tag/v0.1.9

@erikras erikras mentioned this pull request May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikras @swyxio