Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable spring cloud library #193

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Conversation

HugoMario
Copy link
Contributor

No description provided.

@HugoMario HugoMario merged commit 5304bfe into master Oct 2, 2018
@HugoMario HugoMario deleted the disable_spring_cloud_library branch October 2, 2018 15:31
@gerardbosch
Copy link

gerardbosch commented Oct 21, 2018

Hi @HugoMario I spent some time trying to generate the @FeignClient for my API and I've realized thanks to the Christophe Bornet that spring-cloud library was disabled in version 3.0.1. What was the reason for this merge? It seems that FeignClient is working in 3.0.0. I was trying with 3.0.2 and was very hard to understand why I couldn't use spring-cloud library. Is not version 3.0.2 a release version?

I am using swagger-codegen-maven-plugin:

<plugin>
    ...
    <groupId>io.swagger.codegen.v3</groupId>
    <artifactId>swagger-codegen-maven-plugin</artifactId>
    <version>3.0.2</version>

I am trying to understand why spring-cloud support was removed. Thanks.

@HugoMario
Copy link
Contributor Author

Hello @gerardbosch, sorry for this delay answer. We're working on generators in a way to make the output could be able to run properly. Since we couldn't have this ready for spring cloud library we temporarily disabled.

I'm going to start working on enabling this back and let you know.

Sorry for this inconvenient.

@HugoMario
Copy link
Contributor Author

Hey again @gerardbosch FYI spring-cloud library has been enabled now with #229. Please let me know if you have any doubt or need help with something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants