Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate JaxRS Codegen classes #29

Merged
merged 4 commits into from
Mar 7, 2018
Merged

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Mar 1, 2018

This is a first version of JaxRS Codegen classes

Mirgration Guide in the wiki: Swagger Codegen migration (swagger codegen generators repository)

Known issues:

  • Generated code depends from Swagger v2 libraries (as indicated in the help message)
  • Blank spaces in the generated code (handlebars is used instead of mustache, fine-tuning of the templates is requested)

I have tested it by generating the Petstore example for all JaxRS languages (jaxrs-cxf, jaxrs-cxf-cdi, jaxrs-spec, jaxrs-jersey, jaxrs-resteasy-eap, jaxrs-resteasy). Each generated project can be compiled with maven.

I consider this version as good enough to be merged in this repository. This way the community can provide feedback. The known issues can be fixed later.

@HugoMario HugoMario self-requested a review March 7, 2018 04:25
@HugoMario
Copy link
Contributor

@jmini i have not completely review all 200+ files, but the core LGTM, however if any issue is found i'll help to address. Thanks a lot again for this PR 👍

@jmini
Copy link
Contributor Author

jmini commented Mar 7, 2018

Cleanup work in the other repository: swagger-api/swagger-codegen#7781.

During generation of the example for all jaxrs generator, I have noticed some errors. This work is only a first version, and there is still work to do.

@HugoMario
Copy link
Contributor

sure, i'll be working tweaking these and updating samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants