Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Lazily initialize thread pool #945

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/main/resources/handlebars/python/api_client.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class ApiClient(object):
configuration = Configuration()
self.configuration = configuration

self.pool = ThreadPool()
self._pool = None # Use the pool property to lazily initialize the ThreadPool.
self.rest_client = rest.RESTClientObject(configuration)
self.default_headers = {}
if header_name is not None:
Expand All @@ -70,8 +70,15 @@ class ApiClient(object):
self.user_agent = '{{#httpUserAgent}}{{{.}}}{{/httpUserAgent}}{{^httpUserAgent}}Swagger-Codegen/{{{packageVersion}}}/python{{/httpUserAgent}}'

def __del__(self):
self.pool.close()
self.pool.join()
if self._pool is not None:
self._pool.close()
self._pool.join()

@property
def pool(self):
if self._pool is None:
self._pool = ThreadPool()
return self._pool

@property
def user_agent(self):
Expand Down