[Python] Lazily initialize thread pool #945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porting a Swagger Codegen 2 fix to Swagger Codegen 3. The ThreadPool `pool` is only used for async requests. If a client is not making any async requests, the pool is initialized and needs to be shutdown regardless. Taking up resources (threads) and putting a burden on the end user of the generated client to properly shut down the thread pool. swagger-api/swagger-codegen@ebc8313#diff-d7b82d024488f96a18a1c76247f1bd57cbde141f28defe6f45b04ce566ab5aeb
|
Stumbled upon this solution because swagger codegen v3's python client won't work inside of a lambda as generated. I think this will link to the correct issue if you tag a commit or update the description with: Reference: Linking a pull request to an issue using a keyword I think this probably needs to be opened as an issue in this repo though. |
|
any update ? |
|
Could you merge that fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting a Swagger Codegen 2 fix to Swagger Codegen 3.
The ThreadPool
poolis only used for async requests.If a client is not making any async requests, the pool is
initialized and needs to be shutdown regardless. Taking up
resources (threads) and putting a burden on the end user
of the generated client to properly shut down the thread
pool.
swagger-api/swagger-codegen@ebc8313#diff-d7b82d024488f96a18a1c76247f1bd57cbde141f28defe6f45b04ce566ab5aeb
Relates to: swagger-api/swagger-codegen#11141