Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Generate swagger yaml for go client #7281

Merged
merged 1 commit into from
Jan 7, 2018
Merged

[Go] Generate swagger yaml for go client #7281

merged 1 commit into from
Jan 7, 2018

Conversation

bvwells
Copy link
Contributor

@bvwells bvwells commented Dec 30, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @antihax

Description of the PR

Output swagger yaml file when generating go client to address issue #7232.

@bvwells bvwells changed the title Generate swagger yaml for go client Generate swagger yaml for go client #7232 Dec 30, 2017
@wing328 wing328 added this to the v2.4.0 milestone Jan 7, 2018
@wing328 wing328 changed the title Generate swagger yaml for go client #7232 [Go] Generate swagger yaml for go client Jan 7, 2018
@wing328
Copy link
Contributor

wing328 commented Jan 7, 2018

@bvwells thanks for the PR. Other clients do not come with auto-generated swagger.yaml so it's a good try and we'll see if there are more demands for other clients to follow suit.

@wing328 wing328 merged commit 7479fc5 into swagger-api:master Jan 7, 2018
@wing328
Copy link
Contributor

wing328 commented Jan 7, 2018

oops... I should have merged it into 2.4.0 instead. Since this just generate an additional yml file, so it should be ok to include the enhancement in the 2.3.1 patch release.

jimschubert added a commit to jimschubert/swagger-codegen that referenced this pull request Jan 10, 2018
* master: (26 commits)
  [Scala] Fix async helper methods when body is optional (swagger-api#7274)
  [Rust] Recommend style based on 'rustfmt' defaults (swagger-api#7335)
  [Java:vertx] Initialize router in init method and re-use router member to create S… (swagger-api#7234)
  [Scala] Fix missing json4s import (swagger-api#7271)
  deploy snapshot version 2.3.1
  [Ada] Add Ada support for server code generator swagger-api#6680 (swagger-api#7256)
  add shijinkui to scala technical committee
  Generate swagger yaml for go client (swagger-api#7281)
  use openjdk7 in travis to ensure it works with jdk7
  docs(readme): update link to contributing guid (swagger-api#7332)
  Fix a regression bug that was introduce in a recent commit. Removed the tabs that were causing error in Play Framework (swagger-api#7241)
  Fix issue swagger-api#7262 with the parameter name in the path. The problem was that camelCase naming was forced only in this part of the code when everywhere else it is configurable. (swagger-api#7313)
  Java8 fix (swagger-api#7260)
  update to 2.3.1-SNAPSHOT
  fix typo, update 2017 to 2018
  [Doc] add huawei cloud to companies list swagger-api#7308 (swagger-api#7309)
  Adding Peatio opensource as reference project (swagger-api#7267)
  Update README.md (swagger-api#7298)
  Update README.md (swagger-api#7299)
  [all] sys props in CodegenConstants
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants