Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to make Swagger Codegen compatible with JDK7 again #7260

Merged
merged 2 commits into from
Jan 7, 2018

Conversation

amcginn
Copy link
Contributor

@amcginn amcginn commented Dec 27, 2017

As of 2.3.0 release, a change had been made that used Java 8 methods. This PR changes those calls to the equivalent in Java 7. Also reverts the quick-fix of updating the minimum required version.

@wing328
Copy link
Contributor

wing328 commented Jan 3, 2018

@amcginn thanks for the PR. I've also tested with CI (travis) to confirm it's working for Java7.

We'll use Travis rather than CircleCI to catch this moving forward.

@wing328 wing328 added this to the v2.3.1 milestone Jan 3, 2018
@wing328 wing328 merged commit 6c2a583 into swagger-api:master Jan 7, 2018
@wing328 wing328 changed the title Java8 fix Fix to make Swagger Codegen compatible with JDK7 again Jan 7, 2018
jimschubert added a commit to jimschubert/swagger-codegen that referenced this pull request Jan 10, 2018
* master: (26 commits)
  [Scala] Fix async helper methods when body is optional (swagger-api#7274)
  [Rust] Recommend style based on 'rustfmt' defaults (swagger-api#7335)
  [Java:vertx] Initialize router in init method and re-use router member to create S… (swagger-api#7234)
  [Scala] Fix missing json4s import (swagger-api#7271)
  deploy snapshot version 2.3.1
  [Ada] Add Ada support for server code generator swagger-api#6680 (swagger-api#7256)
  add shijinkui to scala technical committee
  Generate swagger yaml for go client (swagger-api#7281)
  use openjdk7 in travis to ensure it works with jdk7
  docs(readme): update link to contributing guid (swagger-api#7332)
  Fix a regression bug that was introduce in a recent commit. Removed the tabs that were causing error in Play Framework (swagger-api#7241)
  Fix issue swagger-api#7262 with the parameter name in the path. The problem was that camelCase naming was forced only in this part of the code when everywhere else it is configurable. (swagger-api#7313)
  Java8 fix (swagger-api#7260)
  update to 2.3.1-SNAPSHOT
  fix typo, update 2017 to 2018
  [Doc] add huawei cloud to companies list swagger-api#7308 (swagger-api#7309)
  Adding Peatio opensource as reference project (swagger-api#7267)
  Update README.md (swagger-api#7298)
  Update README.md (swagger-api#7299)
  [all] sys props in CodegenConstants
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants