Bad interaction between additionalProperties and $ref

[ranma42]

Description

Compiling the following spec into a TypeScript-Fetch client results in invalid code.
Specifically, the generated code contains

export interface GenericMap extends null<String, number> {
}

which the TypeScript compiler rejects.

Swagger-codegen version

I tested it on swagger-codegen 2.2.1 (latest stable), 2.3.0 (7aebcfa) and master (d11d0f8).

Swagger declaration file content or url

...
definitions:
  GenericMap:
    additionalProperties:
      type: integer
  Container:
    type: object
    properties:
      works:
        type: object
        additionalProperties:
          type: string
      breaks:
        $ref: "#/definitions/GenericMap"

Command line used for generation

swagger-codegen generate -i test.yaml -l typescript-fetch

Steps to reproduce

Compile a swagger API containing the definitions mentioned above into a typescript-fetch client.

Further data

This was originally reported as swagger-api/swagger-codegen#4839
@wing328 suggested to report the issue here as it is likely related to some problems with the resolution of the reference.

[webron]

Can you try changing your definition to the following and see if it helps?

...
definitions:
  GenericMap:
    type: object
    additionalProperties:
      type: integer
  Container:
    type: object
    properties:
      works:
        type: object
        additionalProperties:
          type: string
      breaks:
        $ref: "#/definitions/GenericMap"

[ranma42]

On each of the three versions of swagger-codegen I had tested, it generates the very same output as the original spec.

[webron]

Thanks for checking.

[naXa777]

is it resolved in the current version of swagger-parser and swagger-codegen?

[BrandonWalker88]

Has anyone found a solution for this? I'm having the same issue with the typescript-axios vs.

[twistedpair]

Still broken on Codegen v3.0.31.

[SchiessMax]

Tried it on v3.0.34 and the problem still occurs

[mohammedSlimani]

Same issue for the version v3.0.36

[rofenix2]

So is anybody managing this project or what?. People been complaining about this since 2019 and still no answer?.

[alois-git]

Any news about this ?

[skizocell]

Same issue for the version v3.0.44

[skizocell]

Same issue for the version v3.0.50

[threydor]

Still broken for the version v3.0.58